search

logseq / publish-spa

A github action and CLI to publish logseq graphs as a SPA app
MIT License
233 stars 15 forks source link

dev: pass html-options from repo-config #27

Open CNLHC opened 6 months ago

CNLHC commented 6 months ago

Currently, the underlying export function supports receiving a html-options map for configurating the published html but it seems that this cli has not supported this feature yet.

This PR makes the publish-spa cli read the hrml-options from the repo config(a.k.a logsq.edn) and enable the user to control the generated html.

After https://github.com/logseq/logseq/pull/11149 being merged, user can also define extra scripts they want to include into the published html in their logseq.edn

happylolonly commented 2 months ago

@CNLHC will this help for https://github.com/logseq/publish-spa/issues/34 ?

CNLHC commented 2 months ago

@CNLHC will this help for #34 ?

Sure, I think this PR will also solve the #34 with a little change.

happylolonly commented 2 months ago

Cool, lets merge it!

CNLHC commented 2 months ago

Cool, lets merge it!

I can support using user defined meta info( head\title...) in next few days.

But I have no idea when this PR can be reviewed and merged 😿

happylolonly commented 2 months ago

Cool, lets merge it!

I can support using user defined meta info( head\title...) in next few days.

But I have no idea when this PR can be reviewed and merged 😿

Who is owner and can merge? @logseq-cldwalker ?

Also would be good to have options for add more meta types, and scripts. Trying https://github.com/cybercongress/cyber/blob/master/.github/workflows/publish.yml#L28 , but having some .sh errors for now

happylolonly commented 2 weeks ago

@logseq-cldwalker ?