search

logsquaredn / rototiller

0 stars 0 forks source link

Logic around downloading content #153

Closed phish3y closed 2 years ago

phish3y commented 2 years ago

I think our logic around downloading content should be:

  1. Try to download whichever content type was requested (zip/json), 404 if the requested content type doesn't exist
  2. If no content type requested, default to zip first, then fallback to json if zip didn't exist, 500? if found nothing

Thought?

frantjc commented 2 years ago

agree except maybe 404 instead of 500 as the final fallback?

phish3y commented 2 years ago

@frantjc can't decide.. if there's nothing in the output but the job was successful, that sounds more like a 500 to me

frantjc commented 2 years ago

my vote is on 404. If the job failed, the status is failed and there's no output ID, so you shouldn't trying to get an output. Our API did nothing wrong, you're just asking for something that's not there

frantjc commented 2 years ago

OH but the job is successful..still 404 imo

phish3y commented 2 years ago

@frantjc I'm fine with 404