logsquaredn / rototiller

0 stars 0 forks source link

should header content type matter when starting job with a stored dataset #188

Closed phish3y closed 2 years ago

frantjc commented 2 years ago

I'd wager no; if they sent the storage, then there's only one type (json or zip), and we just use that

If they're using the output of another job, then all types are there (as of writing, json and zip) and whatever we use should result in the same output. We can prioritize one if its faster than another, but I don't think the user needs to worry about what type we use.

phish3y commented 2 years ago

@frantjc I agree on everything you said, lets use this ticket to make sure the API doc reflects that the header content type doesn't matter if you're using an existing storage.

Also, there's the case of the lookups where the result is JSON only and not GeoJSON. You can't chain jobs on the job output of these tasks. We should reflect that in the API doc and code. No input-of, etc for those task types.

phish3y commented 2 years ago

There's a partial lie in the second paragraph above. The vecotor lookup actually does produce valid GeoJSON, so you could chain jobs on that. The raster lookup does not, however.

frantjc commented 2 years ago

per discussion on Discord:

phish3y commented 2 years ago

Also update API documentation

frantjc commented 2 years ago

created https://github.com/logsquaredn/geocloud/issues/195 from this discussion, changed from question => documentation as the question has been answered...