generally speaking, we should not return an error produced by Go from the API, we should log it and return a more user friendly error message that doesn't expose application details

logsquaredn / rototiller

0 stars 0 forks source link

generally speaking, we should not return an error produced by Go from the API, we should log it and return a more user friendly error message that doesn't expose application details #235

Open phish3y opened 1 year ago

frantjc commented 1 year ago

I agree in many respects, but, for example, the error from net/mail.Parse is way more useful to a user than we can generically generate (i.e. it literally tells what is wrong with the given email). I think letting errors bubble up sometimes can be OK and useful.

phish3y commented 1 year ago

Also wtf... we don't log very much in the API layer. Need to log errors in the API layer