Optional base64 encoding - Githubissues

logstash-plugins / logstash-codec-avro

A logstash codec plugin for decoding and encoding Avro records

Apache License 2.0

15 stars 63 forks source link

Optional base64 encoding #29

Closed johanvanderkuijl closed 6 years ago

johanvanderkuijl commented 6 years ago

Users can choose if they want the output to be base64 encoded:

codec =>
    avro {
        schema_uri => "/path/to/schema.avsc"
        base64_encoding => false
    }

original-brownbear commented 6 years ago

@Rubyan thanks looking into this shortly

original-brownbear commented 6 years ago

@Rubyan thanks for the patch!

2 points here from my end:

I think it makes sense to use Encoding::ASCII_8BIT as commented inline right?
Also, maybe we should use eval() together with define_singleton_method to dynamically create the decode and encode methods depending on the setting?
- This is more of a note for me, I'll benchmark this and code it up if it is necessary :)

original-brownbear commented 6 years ago

link https://github.com/logstash-plugins/logstash-output-kafka/pull/162

original-brownbear commented 6 years ago

@Rubyan see #30, I implemented this via a dynamically set up method and set the StringIO to binary encoding. Let me know if it works as expected with those changes :)

jsvd commented 6 years ago

can we close this in favor of #30? it seems there that the PR solves the problem

original-brownbear commented 6 years ago

@jsvd yea, sorry for the delay on #30. Will do my best to continue there shortly (as in the beginning of next week).