search

logstash-plugins / logstash-codec-collectd

Apache License 2.0
6 stars 11 forks source link

Ensure that notifications are received properly #11

Closed untergeek closed 9 years ago

untergeek commented 9 years ago

Reported in #10

Fixed, and added a test.

fixes #10

jsvd commented 9 years ago

@untergeek I don't think the changes in "lib" fix anything related to the new specs. I tried the new specs on master and they still all pass.

untergeek commented 9 years ago

I think I know why. I'm only sending a single packet, and that would work. It breaks when a string of packets go through.

I'll have to see if I can string a bunch of packets together to force the test. The message and severity field don't propagate otherwise.

jsvd commented 9 years ago

Ran the tests and they pass :+1: small note: only the change 91 is required to make specs pass. after talking to @untergeek understood they target other issues with collectd decoding and are also necessary. LGTM