search

logstash-plugins / logstash-codec-json

Apache License 2.0
23 stars 29 forks source link

Support arrays at source root by emitting multiple events. Fixes #12 #13

Closed andrewvc closed 9 years ago

andrewvc commented 9 years ago

Fixes #12

suyograo commented 9 years ago

@andrewvc can we document that this will happen (multiple events if array is supplied) at the top of the file? https://github.com/logstash-plugins/logstash-codec-json/blob/master/lib/logstash/codecs/json.rb#L14

jordansissel commented 9 years ago

Code LGTM. There are edge cases (array of something-not-objects), but I think this is a good step forward. Let's add documentation to describe the [ {...}, {...}, ... ] support and behavior.

Test code looks good. I haven't run them yet.

jordansissel commented 9 years ago

Tests pass for me. Woo! :green_apple:

andrewvc commented 9 years ago

@jordansissel cool, will release the new gem then! :rocket:

elasticsearch-bot commented 9 years ago

Merged sucessfully into master!