search

logstash-plugins / logstash-codec-json

Apache License 2.0
23 stars 29 forks source link

use Event#from_json if available #21

Closed colinsurprenant closed 8 years ago

colinsurprenant commented 8 years ago

relates to https://github.com/elastic/logstash/pull/4631and elastic/logstash#4595

similar PR as logstash-plugins/logstash-codec-json_lines/pull/19 to support the new Event#from_json if available when using the Java Event.

talevy commented 8 years ago

looks good, have the same concern about testing as mentioned here: https://github.com/logstash-plugins/logstash-codec-json_lines/pull/19#issuecomment-181516407

colinsurprenant commented 8 years ago

@talevy I used the same strategy as json_lines, let me know if all good.

talevy commented 8 years ago

small comment, ott LGTM

colinsurprenant commented 8 years ago

thanks, squashing, bumping and merging.

colinsurprenant commented 8 years ago

published 2.1.0