Closed guyboertje closed 8 years ago
So, to clarify, the intended usage is to be able to call encode(event, identity)
as an extension to the current Codec API?
This currently looks great to me code-wise btw!
@guyboertje I'd like to hop on a zoom with you monday just to make sure I have all the details straight, but it LGTM!
Minor comments, code LGTM!
I have tested this with concurrent-ruby 0.9.1 and tests passes
@guyboertje thanks for answering my questions, for concurrent-ruby just make an issue for the migration path. I expect both gem thread_safe
and concurrent-ruby
to concurrently work ;)
Lgtm sorry my last comment wasn't clear enough
Merged sucessfully into master!
also has tests
Follows on from this closed PR on core - https://github.com/elastic/logstash/pull/4104
NOTES TO REVIEWERS:
If you have read or commented on the first PR, these are the important differences:
Fixes #10