Prepare for Auto-flush, introduce listeners to carry state with callback API

guyboertje commented 8 years ago

NOTES TO REVIEWERS:

Both the IdentityMapCodec and the Multiline have been changed.
Both are backward compatible and retain the block based API.
New accept method that takes a listener as an argument.
For these two classes, Listeners must implement accept() and process_event(event).
Listeners usually hold long term upstream state (context) and transient data for downstream to process.
The listener based tests are a WIP and will be tidied up.
A lot more comments need to be added.
Some classes will need to be in their own files but are included for readability.
These changes are a prelude to a better component based dataflow channel in each input.
Auto-flush is implemented.

ph commented 8 years ago

Added minor comments, address them and we can merge.

Also I fixed the issue with concurrent-ruby on the jenkins server you can see a build of this PR at http://build-eu-00.elastic.co/job/logstash-plugin-codec-multiline_PR/10/console

guyboertje commented 8 years ago

Oops - changed the evict method. will fix test.

guyboertje commented 8 years ago

specs pass locally

guyboertje commented 8 years ago

again specs pass locally after spec helper re-org.

ph commented 8 years ago

Make sure you add the changes to the changelod.md and bump the version so I can review those and make sure we squash the PR.

but the code lgtm and the test pass.

guyboertje commented 8 years ago

OK.

ph commented 8 years ago

LGTM

logstash-plugins / logstash-codec-multiline