search

logstash-plugins / logstash-codec-multiline

Apache License 2.0
7 stars 31 forks source link

remove obsolete seting `type` from example #33

Closed kidmose closed 7 years ago

kidmose commented 8 years ago

The example raises this error when I use it with logstash 2.3.1:

The setting type in plugin multiline is obsolete and is no longer available. You can achieve this same behavior with the new conditionals, like: if [type] == \"sometype\" { multiline { ... } }. If you have any questions about this, you are invited to visit https://discuss.elastic.co/c/logstash and ask.

jordansissel commented 8 years ago

@kidmose Thanks for your contribution!

Looks like the CLA check failed. Can you read http://www.elasticsearch.org/contributor-agreement/ and sign it? We can proceed with review after that.

kidmose commented 8 years ago

CLA signed. Quite a lot of paper for such a minor fix..

jsvd commented 7 years ago

since this documentation example is incorrect (uses filter multiline instead of codec multiline). I'm closing this PR in favor of #45 thank you for you contribution @kidmose, and sorry for the long time to respond.