search

logstash-plugins / logstash-codec-multiline

Apache License 2.0
7 stars 31 forks source link

#58 make clone method safe #60

Closed original-brownbear closed 6 years ago

original-brownbear commented 6 years ago

Fixes #58

The problem was that our clone method wasn't safe (not the flush as I initially thought). This lead to the @buffer array being shared across instances in some situations when using .cloned instances of the code in multi-threaded inputs like the udp input. => fixed by making .clone set up a clean buffer via register fixes this (as well as ensures that we set up the codec's mutable state cleanly for the clones in general)

original-brownbear commented 6 years ago

@yaauie can you double check the changelog here please so we can release this? Thanks!

original-brownbear commented 6 years ago

@yaauie thanks!

elasticsearch-bot commented 6 years ago

Armin Braun merged this into the following branches!

Branch Commits
master cc29951dba1811eac98826be04fff67562bbd9cd, b1c9ad98fc31e9b1eccef288bd06dbf37060eaff