search

logstash-plugins / logstash-codec-multiline

Apache License 2.0
7 stars 31 forks source link

Fix an issue when the buffered events make logstash go OOM. #7

Closed ph closed 9 years ago

ph commented 9 years ago

Fix an issue when the buffered events is never send to pipeline and just keep growing and make logstash go OOM. I have added a max_lines options to force a flush to queue after a maximum buffered events is saved in the buffer, default is set to 100 lines.

Fixes: https://github.com/logstash-plugins/logstash-codec-multiline/issues/4, https://github.com/elastic/logstash/issues/2984, https://github.com/elastic/logstash/issues/2015

ph commented 9 years ago

@colinsurprenant do not review it yet, after reading other report of crash I'll add a bytesize check on this too.

ph commented 9 years ago

@suyograo @colinsurprenant ready for review.

ph commented 9 years ago

Also the default max_bytes is currently arbitrary, any recommended way to come up with a sane default?

ph commented 9 years ago

@colinsurprenant updated!

colinsurprenant commented 9 years ago

LGTM - not tested

elasticsearch-bot commented 9 years ago

Merged sucessfully into master!