search

logstash-plugins / logstash-codec-netflow

Apache License 2.0
79 stars 88 forks source link

fix netflow and ipfix data type inconsistencies #191

Closed robcowart closed 2 years ago

robcowart commented 4 years ago

The data types of information elements supported by IPFIX and Netflow were out of sync. This PR corrects this, as well as cleans up of this section of code and a few comments.

robcowart commented 2 years ago

@jsvd Is this PR just being ignored without comment? Why was it closed?

jsvd commented 2 years ago

@robcowart apologies, github did it automatically after a rename operation of the master branch to main. still investigating why a few prs were retargetted and others werent

[edit] seems to be because the PR changes come from a branch that no longer exists: robcowart:netflow_ipfix_types_consistency, or https://github.com/robcowart/logstash-codec-netflow/tree/netflow_ipfix_types_consistency

robcowart commented 2 years ago

Understood. In all fairness this PR is likely unimportant now. Given the issues that this codec has handling netflow records properly, as well as performance issues, I have transitioned ElastiFlow to an all-new purpose built collector and archived the legacy solution that used Logstash. These changes may still be important to some, but no longer to most ElastiFlow users.