search

logstash-plugins / logstash-codec-nmap

NMap XML decoding for logstash
Apache License 2.0
28 stars 25 forks source link

allow 5.2 functionality #11

Closed rwaweber closed 7 years ago

rwaweber commented 7 years ago

https://github.com/logstash-plugins/logstash-codec-nmap/pull/10 seems to have been stationary for a bit now. I would very much like to get functionality for this in 5.2. This is also a want from others as evidenced by https://github.com/logstash-plugins/logstash-codec-nmap/issues/9.

rwaweber commented 7 years ago

@andrewvc Not sure how to pass the CLA check after I've already signed the document, short of whitespace commits.

karmi commented 7 years ago

Hi @rwaweber, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

karmi commented 7 years ago

Hi @rwaweber, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

rwaweber commented 7 years ago

@karmi Apologies, I've added the email now.

skoudis commented 7 years ago

When will this be finalized for use with Logstash 5.2? My project to use this with nmap & OpenVAS is stalled. Thank you for fixing the plugin.

rwaweber commented 7 years ago

@skoudis I think thats up to the maintainer of this plugin.

In an attempt to alleviate your stalled-ness you could install the plugin manually, but it does take a bit of effort outlined here.

I found the simplest means to go about getting jruby ironed out using rvm, then gem install logstash-devutils bundler and you should be set to follow the readme from there.

suyograo commented 7 years ago

LGTM

rwaweber commented 7 years ago

Not sure if I'm doing something incorrectly when trying to install this plugin on my logstash machine, but I'm performing the following with little success, without building the plugin locally.

Attempt 1

  1. bin/logstash-plugin install logstash-codec-nmap
  2. Yields this (yikes).
  3. The important bits here and here seem to indicate that the logstash-plugin repo thinks that the logstash-codec-nmap package is at version 0.

Attempt 2

  1. I added `` to the Gemfile in the root of my logstash directory.
  2. bundle update
  3. Got me a bit closer with some red colorized output, however it seems to think that the latest logstash-codec-nmap package is at version 0.0.15(from the perspective of the logstash-core-plugin-api install process), which is not correct according to the releases here. Additionally, the logstash-core install process seems to resolve to 0.0.1 which befuddles me.

Any clarification or assistance on the above scenarios would be much appreciated!

Aside

gmoskovicz commented 7 years ago

@rwaweber seems to be that we didn't publish this yet: https://rubygems.org/gems/logstash-codec-nmap/ . Version 0.0.17 is not there yet, so we need to release it .

skoudis commented 7 years ago

@gmoskoviczj is it possible to publish this soon so we have a fully functional solution to the nmap codec plugin? Thank you

gmoskovicz commented 7 years ago

@suyograo ^^

suyograo commented 7 years ago

Published 0.0.17 now