search

logstash-plugins / logstash-codec-nmap

NMap XML decoding for logstash
Apache License 2.0
28 stars 25 forks source link

Fix bug in gemspec that broke LS 5.x #12

Closed andrewvc closed 7 years ago

andrewvc commented 7 years ago

This substitutes a ~> for a => in the gemspec so this works right in LS 5.x.

ph commented 7 years ago

From the test, this plugin seem to use the old 2.X syntax to access the event fields.

     NoMethodError:
       Direct event field references (i.e. event['field']) have been disabled in favor of using event get and set methods (e.g. event.get('field')). Please consult the Logstash 5.0 breaking changes documentation for more details.
     Shared Example Group: "a valid parse" called from ./spec/codecs/nmap_spec.rb:75
elasticsearch-bot commented 7 years ago

Andrew Cholakian merged this into the following branches!

Branch Commits
master 87b17c69e41521a816a23cdac83a7cb08ced63da