Enable threadsafe = false flag like in multiline filter?

logstash-plugins / logstash-filter-aggregate

The aim of this filter is to aggregate informations available among several events (typically log lines) belonging to a same task, and finally push aggregated information into final task event.

Apache License 2.0

43 stars 40 forks source link

Enable threadsafe = false flag like in multiline filter? #27

Open alkuzad opened 8 years ago

alkuzad commented 8 years ago

I was looking into new features of ELK and I noticed that they've added the option for plugin to specify that it won't work with multiple workers. From https://github.com/logstash-plugins/logstash-filter-multiline/blob/master/lib/logstash/filters/multiline.rb

    # this filter cannot be parallelized because message order
    # cannot be garanteed across threads, line #2 could be processed
    # before line #1
    @threadsafe = false

Is it good to add such feature to aggregate ?

fbaligand commented 8 years ago

Hi @alkuzad,

I think it could be a good idea. I see two interests :

avoid to explicitly set worker filters to 1
avoid to make synchronization work in plugin, which could improve plugin performance.

I have to make tests to be sure that this flag implies 1 filter worker.

painslie commented 4 years ago

Is the @threadsafe = false still under consideration? This improvement would be much appreciated.