logstash-plugins / logstash-filter-date

Apache License 2.0
7 stars 43 forks source link

Log a debug message when parsing fails. #119

Open jordansissel opened 6 years ago

jordansissel commented 6 years ago

This restores some behavior that was mistakenly removed in v3.0.0 (compared to v2.x) of this plugin.

The previous behavior (v2.x) would log a warning when all matches failed.

This patch brings this behavior back with some slight modifications:

1) It does not use structured logging (because we don't have a simple way to do this in log4j2 yet, as compared to our ruby logging style) 2) It logs at debug level. In 2.x, it logged at warning. 3) All parse failures are logged. In 2.x, only the last match-failure was logged.

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/