logstash-plugins / logstash-filter-date

Apache License 2.0
7 stars 43 forks source link

Cannot build the master branch of the `logstash-date-filter` #85

Closed ph closed 7 years ago

ph commented 7 years ago

The gradle build is failling and complaining about a missing class.

:distZip UP-TO-DATE
:compileJava
Download https://repo1.maven.org/maven2/joda-time/joda-time/2.9.4/joda-time-2.9.4.pom
Download https://repo1.maven.org/maven2/joda-time/joda-time/2.9.4/joda-time-2.9.4.jar
/home/travis/build/logstash-plugins/logstash-filter-date/src/main/java/org/logstash/filters/DateFilter.java:89: error: cannot access Queueable
            event.tag(t);
                 ^
  class file for org.logstash.ackedqueue.Queueable not found
1 error
:compileJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug opt

Full trace: https://travis-ci.org/logstash-plugins/logstash-filter-date/builds/186838287

This problem was discovered in https://github.com/elastic/logstash/pull/6404#issuecomment-269786141 because the version 3.1.2 of the gems was missing the jar, I think this version was manually published because jarvis would never allow it to be pushed because of a failling travis job.

3.1.2 was yanked from rubygems.

ph commented 7 years ago

from 3.1.1 to 3.1.2 appear to be only docs changes.

Docs: Fix date format used in examples

jordansissel commented 7 years ago

Strangely, it builds for me, but I do notice my gradle.properties, when generated, points at Logstash 5.0.0, not 5.1.2

% git rev-parse master
ef3b6c402709b2190408852f7c299a3db654b508

% rm -fr build buildSrc/build vendor gradle.properties

% bundle exec rake gradle.properties
-------------------> Wrote /home/jls/projects/logstash-filter-date/gradle.properties
logstashCoreGemPath=/home/jls/.rvm/gems/jruby-1.7.24/gems/logstash-core-5.0.0-java
logstashCoreEventGemPath=/home/jls/.rvm/gems/jruby-1.7.24/gems/logstash-core-event-java-5.0.0-java
jordansissel commented 7 years ago

Ok I can confirm that:

% ./gradlew assemble
...
:compileJava
/home/jls/projects/logstash-filter-date/src/main/java/org/logstash/filters/DateFilter.java:89: error: cannot access Queueable
            event.tag(t);

% cat gradle.properties
logstashCoreGemPath=/home/jls/.rvm/gems/jruby-1.7.24/gems/logstash-core-5.1.1-java
logstashCoreEventGemPath=/home/jls/.rvm/gems/jruby-1.7.24/gems/logstash-core-event-java-5.1.1-java
jordansissel commented 7 years ago

logstash-core gem v5.1.1 is missing jars:

% find /home/jls/.rvm/gems/jruby-1.7.24/gems/logstash-core-5.1.1-java -name '*logstash*jar'
<no output>

% find /home/jls/.rvm/gems/jruby-1.7.24/gems/logstash-core-5.0.0-java -name '*logstash*jar'
/home/jls/.rvm/gems/jruby-1.7.24/gems/logstash-core-5.0.0-java/vendor/jars/org/logstash/logstash-core/5.0.0/logstash-core-5.0.0.jar
jsvd commented 7 years ago

I still can't run rake vendor, after the release of 5.1.1.1 core gems:

I tried doing bundle install --path=vendor, and checked that the jars are in the vendor directory:

logstash-filter-date/vendor (git)-[master] % find . -name 'logstash*.jar'
./jruby/1.9/gems/logstash-core-5.1.1.1-java/lib/logstash-core/logstash-core.jar
./jruby/1.9/gems/logstash-core-event-java-5.1.1.1-java/lib/logstash-core-event-java/logstash-core-event-java.jar
./jruby/1.9/gems/logstash-core-queue-jruby-5.1.1.1-java/lib/logstash-core-queue-jruby/logstash-core-queue-jruby.jar
jsvd commented 7 years ago

this has been fixed by https://github.com/logstash-plugins/logstash-filter-date/pull/87