search

logstash-plugins / logstash-filter-geoip

Apache License 2.0
64 stars 82 forks source link

Fields is missing region_code #156

Closed untergeek closed 5 years ago

untergeek commented 5 years ago

region_code is still a valid field to extract, but was not in the docs.

On a separate note, I believe that country_code3 is no longer 3 characters, but 2 (extracted from the same field as country_code2), and perhaps should continue to exist, since users may expect it.

colinsurprenant commented 5 years ago

CI is failing but I believe for unrelated reasons.

untergeek commented 5 years ago

That is odd. I didn't touch any code. Just added docs. 🤷‍♂️

untergeek commented 5 years ago

There it is:

Downloading http://geolite.maxmind.com/download/geoip/database/GeoLite2-City.mmdb.gz
rake aborted!
SHA1 does not match (expected 'e052a7f529ea616d4479ed2785863a8d8b7094aa' but got '850fc44959352984c99853ed5b929a68fedfc1a0')

I believe MaxMind just updated the db. When I downloaded a local copy last night for testing, it had a date stamp in the unzipped directory, GeoLite2-City_20190716. I compared the two, and they are identical.

$ http://geolite.maxmind.com/download/geoip/database/GeoLite2-City.mmdb.gz
$ shasum GeoLite2-City.mmdb.gz
850fc44959352984c99853ed5b929a68fedfc1a0  GeoLite2-City.mmdb.gz
$ gunzip GeoLite2-City.mmdb.gz
$ diff GeoLite2-City.mmdb GeoLite2-City_20190716/GeoLite2-City.mmdb
robbavey commented 5 years ago

@untergeek, @colinsurprenant A rebase against latest should fix the CI issues here

colinsurprenant commented 5 years ago

@untergeek did you want to rebase it? otherwise I can reboot the PR and look into it, let me know.

untergeek commented 5 years ago

Please feel free to reboot it. I did an online edit so I don't have a local branch to rebase and force push.

colinsurprenant commented 5 years ago

rebooted in #158, closing.