search

logstash-plugins / logstash-filter-geoip

Apache License 2.0
64 stars 82 forks source link

Enable the use of MaxMind GeoIP2-Domain databases #162

Closed Sitwon closed 3 years ago

Sitwon commented 4 years ago

In addition to the location databases, MaxMind provides a database of domain data as well. This change enables the use of the GeoIP2-Domain database by whitelisting the appropriate field.

andsel commented 4 years ago

Hi @Sitwon thanks for you contribution, before anybody could start to review, please sign the committer license agreement, CLA. Thanks

Sitwon commented 4 years ago

Hi, I signed the CLA and downloaded the PDF copy. Is there another step I need to take?

On Thu, Feb 6, 2020, 03:53 Andrea Selva notifications@github.com wrote:

Hi @Sitwon https://github.com/Sitwon thanks for you contribution, before anybody could start to review, please sign the committer license agreement, CLA. Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/logstash-plugins/logstash-filter-geoip/pull/162?email_source=notifications&email_token=AAAXV6AL4BINPXI53QJCCLDRBPFZBA5CNFSM4KQN3XWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK6NAPQ#issuecomment-582799422, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXV6FUYAYSNF3L2MZATDTRBPFZBANCNFSM4KQN3XWA .

Sitwon commented 4 years ago

I see, I just had to amend the commit author to use the same email address I gave for the CLA.

Sitwon commented 4 years ago

@andsel I've signed the CLA.

The build failure in Travis does not seem to be related to my change. It looks like Travis timed out trying to download https://services.gradle.org/distributions/gradle-5.6.4-bin.zip.

Sitwon commented 3 years ago

174 is asking for this to be merged. I'm still not clear on what's holding it up. The Travis CI failure is unrelated to this change.

roaksoax commented 3 years ago

@Sitwon Thank you for taking the time to contribute and to following up with this PR, and sorry for the delayed response. @kaisecheng will review your PR and approve/request changes as appropriate!