logstash-plugins / logstash-filter-geoip

Apache License 2.0
64 stars 82 forks source link

Retrieve logstash-core gem's path using inline bundler #218

Closed andsel closed 1 year ago

andsel commented 1 year ago

Release notes

[rn:skip]

What does this PR do?

Avoid to fork a bundler process to extract logstash-core's path and use the same bundler that wraps the execution of the Rakefile itself.

Why is it important/What is the impact to the user?

All the Rake tasks must run with same JRuby distribution that launched the execution. Without this, it uses the system's Ruby.

Checklist

Author's Checklist

How to test this PR locally

Verify that it works with Logstash JRuby distribution:

export LOGSTASH_PATH=/tmp/logstash/ && export LOGSTASH_SOURCE=1
/tmp/logstash/bin/ruby -S bundle install
/tmp/logstash/bin/ruby -S exec rake vendor

Related issues

andsel commented 1 year ago

Note: 🔴 CI is already present also on the main : https://app.travis-ci.com/github/logstash-plugins/logstash-filter-geoip/builds/267431039