Change default timeout / Allow timeout to be disabled

logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.

https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html

Apache License 2.0

122 stars 97 forks source link

Change default timeout / Allow timeout to be disabled #101

Closed andrewvc closed 7 years ago

andrewvc commented 7 years ago

As seen in #99 sometimes there may be cases where the 2s timeout is too short. 30s is a more sane default. We should also allow timeouts to be disabled in case it does turn out to be a race condition after all we want people to be able to disable the feature without an upgrade. Also, some people may never want to time out.

suyograo commented 7 years ago

LGTM

jordansissel commented 7 years ago

LGTM

elasticsearch-bot commented 7 years ago

Andrew Cholakian merged this into the following branches!

Branch	Commits
master	c844745210487d64e07e5cfd309bbb779676bc40, 2cfc0266ef41428e08bc5e49748024e62398e717, 2c168b8b1dc8e083419b78d4ed590cd64122cdcd