# 110 Globs that Return Subdirectories Error out

logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.

https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html

Apache License 2.0

124 stars 97 forks source link

# 110 Globs that Return Subdirectories Error out #111

Closed original-brownbear closed 7 years ago

original-brownbear commented 7 years ago

closes #110

Fixed by https://github.com/logstash-plugins/logstash-filter-grok/compare/master...original-brownbear:110?expand=1#diff-0d9c333ff736a82e8686ba9c4bb5e919L393
- Since this is all private methods we need to just make sure that globbing for files won't return directories too
Added test
2 small cleanups (gitignore .idea + autocleanup redundant qualifier on Java import)

original-brownbear commented 7 years ago

@guyboertje fyi :)

original-brownbear commented 7 years ago

@guyboertje moved to Stud::Temporary as discussed :)

suyograo commented 7 years ago

Nice. LGTM

suyograo commented 7 years ago

@original-brownbear remember to bump version, changelog and publish :)

suyograo commented 7 years ago

@original-brownbear since you are in this area, this is another candidate for a java rewrite (should continue using Joni to keep backward compatibility with regexes). Something on your list if you are looking for more things :)

It would be interesting to see what the benchmark results are for the 2 implementations.

/cc @jsvd

original-brownbear commented 7 years ago

@suyograo bump version in this PR or are we always doing a separate one for that?

original-brownbear commented 7 years ago

@suyograo Also, I'll add a separate issue for a Java redo then?

original-brownbear commented 7 years ago

@jordansissel all fixed I think :)

suyograo commented 7 years ago

@original-brownbear you can bump version and changelog in the same PR.

original-brownbear commented 7 years ago

@suyograo bumped version and added changelog entry :)

original-brownbear commented 7 years ago

issue about Java version: https://github.com/logstash-plugins/logstash-filter-grok/issues/112

elasticsearch-bot commented 7 years ago

Armin Braun merged this into the following branches!

Branch	Commits
master	8c32f3d9d8a25d8ba1764f1fa9af4771e6e68dc6, 4527ef798fb1234d43cc7a011445e5169d3aa3d7, 7291a480e3d204983576d2323ee7c777e2bcbd1a, e5f3ee9c20186b4ea2b0e0dcdb22eed994496fd5, 1f6d1c246a9c392ff75481c86471a9a652c646df, ccf7cb4ae5457ce98c9df4537aa6fb50edd9d916, 58db89686b001ed4e8794345541248e526abddf0, e5d432f83f8ff80af1b8eb67e328c2d9f29a0080