#127 fix test randomly failing from incorrect assumption about key order in JSON hash

logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.

https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html

Apache License 2.0

122 stars 97 forks source link

#127 fix test randomly failing from incorrect assumption about key order in JSON hash #128

Closed original-brownbear closed 6 years ago

original-brownbear commented 6 years ago

Fixes random test failures described in #127.

The failures happen when tags is not the last key in the generated json, which is not guaranteed to be so (but seems to happen every time with older JrJackson/LS versions, not so with master and 6.x).

=> Simply fix the string matcher to not assume tags to be followed by the closing }.

original-brownbear commented 6 years ago

@jsvd thanks!

elasticsearch-bot commented 6 years ago

Armin Braun merged this into the following branches!

Branch	Commits
master	a3d292ab5470b2ba2e4bfaec8e6cfe63ead839f0