logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.
https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html
Apache License 2.0
122 stars 97 forks source link

Convert CI unit tests to use docker images. #141

Closed jakelandis closed 4 years ago

jakelandis commented 6 years ago

Alternative to https://github.com/logstash-plugins/logstash-filter-grok/pull/139 for discussion.

Run unit tests from within docker containers via Docker compose.

Similar to https://github.com/logstash-plugins/logstash-filter-grok/pull/139:

Dis-similar to https://github.com/logstash-plugins/logstash-filter-grok/pull/139

jakelandis commented 6 years ago

This is what a unit/integration testing pair could look like, both using docker.

https://github.com/jakelandis/logstash-input-azure_event_hubs/tree/re-implement-with-event-processor-host/ci

To run the unit tests ci/unit/docker-test.sh To run the integration tests ci/integration/docker-test.sh

(note the above example uses a manual integration testing method, but can be evolved to a pure automated test without changing the general structure).

webmat commented 6 years ago

I really love the ability to run the integration tests reliably locally. If they fail, they will also fail in Travis, and they need to be fixed.

You're sure not to be missing any special quirk (e.g. "don't run ElasticSearch when you run the output-es tests").

jakelandis commented 4 years ago

closing this PR as stale