search

logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.
https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html
Apache License 2.0
122 stars 97 forks source link

update to centralized travis configuration #159

Closed jsvd closed 4 years ago

jsvd commented 4 years ago

this depends on performance testing support in central travis setup PR https://github.com/logstash-plugins/.ci/pull/11

before merging, line https://github.com/logstash-plugins/logstash-filter-grok/pull/159/files#diff-354f30a63fb0907d4ad57269548329e3R4 must be changed to branch 1.x

[edit] tried some caching strategies to reduce performance phase time, but gave up for now (couldn't get travis to reuse docker images)

[edit] CI failed on performance specs, not related to this PR (I think? )

kares commented 4 years ago

[edit] CI failed on performance specs, not related to this PR (I think? )

yes, this is in my todo list :low_brightness: - the performance tests are not really that useful on CI atm. sometimes they work but usually there's at least one failure as the underlying machine changes.

jsvd commented 4 years ago

now that https://github.com/logstash-plugins/.ci/pull/11 has been merged, I've added 43df138 to this PR, and it's therefore ready to merge on my end.