logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.
https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html
Apache License 2.0
122 stars 97 forks source link

Feat: ECS compatibility support #162

Closed kares closed 3 years ago

kares commented 4 years ago

also made LS::Environment's pattern_path optional

POST: cleanup patterns core depending on this branch as a gem dependency

resolves #157

kares commented 4 years ago

@yaauie when you get a chance - the loading part (this PR) should be quite simple. what I am struggling with is what will be the best (new) layout at logstash-patterns-core :

yaauie commented 4 years ago

On directory layout, I'm okay with your proposed hyphenated renames, but a nested structure could give us the opportunity to inject documentation. I agree that it's worth breaking the in-flight PRs (but also that we really need to expend some effort to bring some of those suggestions forward).

patterns/
  README.md <-- define the path forward and how a set of patterns is loaded by default
  legacy/*
  ecs-v1/*
  ecs-v2/*

On adding a selector to LogStash::Patterns::Core#path, I see no reason to make this a major, so long as it continues to work as-is when no selector is provided.