[DOCS] Grok - Fix missing quotes for field matching

logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.

https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html

Apache License 2.0

122 stars 97 forks source link

[DOCS] Grok - Fix missing quotes for field matching #183

Closed ugosan closed 1 year ago

ugosan commented 1 year ago

Fix missing quotes for field matching

wallrik commented 1 year ago

This is the 4th PR addressing the same thing 😅 I've had one open for 5 months... 😁 %{NUMBER"number} needs a colon instead of the quote, as well.

ugosan commented 1 year ago

lets address all those in a single PR then

wallrik commented 1 year ago

lets address all those in a single PR then

For sure! If you're able to merge to this repo, my PR (#176) should already be sufficient, and has been reviewed. 👍

I just had to comment when I saw your Elastic team tag. 😇 I'm not familiar with merge procedures at Elastic and why nothing is getting merged over here for months. If it's the build tests failing? That's possibly an ecs_compatibility issue? (#178)

jsvd commented 1 year ago

fixed in #176