Closed elyscape closed 8 years ago
Thanks a lot for your contribution @elyscape, in order to move forward with your PR is going to be necessary to sign the CLA agreement, you can find more information at https://www.elastic.co/contributor-agreement.
/cheers
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.
please jenkins, test this.
@purbon CLA signed. Sorry about the delay.
Pinging @purbon.
Pinging @jsvd and @colinsurprenant for review.
LGTM
Suyog Rao merged this into the following branches!
Branch | Commits |
---|---|
master | a6532cfaa4745c4ecf20be5ebf6fe320b6b7d206 |
patterns_dir only accepts an array as input, but one of the examples used a regular string. This implied that it would allow non-array string input, which isn't the case.
Is there a way to update the documentation on the site for the old versions with this fix as well? Because, as it stands, this could confuse someone (e.g. me) who, using an old version of logstash/grok, checks the documentation for that particular version.