search

logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.
https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html
Apache License 2.0
124 stars 98 forks source link

Grok tag_on_failure not deprecated #56

Closed pemontto closed 8 years ago

pemontto commented 8 years ago

I was reading the docs and noticed that tag_on_failure is not marked deprecated even though tags are. Is this likely to be updated or replaced by writing to a user defined field?

wiibaa commented 8 years ago

@pemontto there is a misundertanding, the usage of tags in an event is not deprecated at all. so the tag_on_faiulre is still valid to use. What is deprecated is event filtering with filter parameters like tags. Using conditionals statement around the filter like if "failure" in [tags] is the way to go.

pemontto commented 8 years ago

Thanks for the clarification wilbaa