search

logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.
https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html
Apache License 2.0
124 stars 98 forks source link

Add test for correct JSON serialisation after grok #58

Closed guyboertje closed 7 years ago

guyboertje commented 8 years ago

with JrJackson v 0.3.5 this test should fail. Fixed with JrJackson v 0.3.6.

Reviewer: If you run this tests locally make sure the version logstash-core includes newer version of JrJackson because some earlier releases of 2.0 have JrJackson 0.2.9 which will not fail the test.

purbon commented 8 years ago

please jenkins, test this.

elasticsearch-release commented 8 years ago

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

purbon commented 8 years ago

please jenkins, test this.

guyboertje commented 8 years ago

@purbon - is this OK?

purbon commented 8 years ago

LGTM

guyboertje commented 8 years ago

@suyograo - I am not sure who to assign this to for review - everyone seems to have something that they are working on. Aaron perhaps?

elasticsearch-bot commented 7 years ago

João Duarte merged this into the following branches!

Branch Commits
master f4f6d6c54d9907ec5fb91ae55c2b7d873c27243a