search

logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.
https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html
Apache License 2.0
124 stars 98 forks source link

Feature allow glob pattern for patterns_dir #63

Closed breml closed 8 years ago

breml commented 8 years ago

Added the possibility to specify a glob pattern for the pattern files in patterns_dir.

May be a solution for #33, without breaking compatibility.

elasticsearch-release commented 8 years ago

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

breml commented 8 years ago

Could please someone give me some feedback? I will fix the conflict, if there is some interest in merging this one.

breml commented 8 years ago

Resolved the conflict, please have a look.

jordansissel commented 8 years ago

jenkins, test it

jordansissel commented 8 years ago

Code LGTM. Tests pass for me.

jordansissel commented 8 years ago

(I'll fix some of the style concerns post-merge)

jordansissel commented 8 years ago

Merged into master after rebasing and doing some style cleanup (faf47b3b66015d95d37cd10f9b4d72c69216714a)

Thank you :)