logstash-plugins / logstash-filter-grok

Grok plugin to parse unstructured (log) data into something structured.
https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html
Apache License 2.0
124 stars 97 forks source link

Fix race in timeout exception #96

Closed andrewvc closed 7 years ago

andrewvc commented 7 years ago

Previously we could see errors as in #95 due to some very esoteric race conditions where Thread#raise would raise outside of the rescue context. This patch changes the mechanism to be setting Thread.interrupt which is more robust.

jordansissel commented 7 years ago

LGTM; specs pass on my workstation.

elasticsearch-bot commented 7 years ago

Andrew Cholakian merged this into the following branches!

Branch Commits
master 671be60e909d9a693c3c8f01fbb567036186d6a5