logstash-plugins / logstash-filter-http

HTTP Filter Plugin for Logstash
Apache License 2.0
12 stars 29 forks source link

[Doc] improvements and clarifications #9

Closed karenzone closed 5 years ago

karenzone commented 5 years ago

This PR:

To Do:

karenzone commented 5 years ago

The formatting for validate_after_inactivity wasn't rendering correctly.

screen shot 2019-02-01 at 4 24 23 pm

I took a guess at what you were going for, and reformatted and reworded it a bit.

Here's how it's rendering now:

screen shot 2019-02-01 at 5 11 21 pm
jsvd commented 5 years ago

@karenzone well spotted, this was essentially a copy of the settings that all plugins that use the logstash-mixin-http_client has, since we don't have a nice way to fetch these from another repository.

So I copied over the settings from a plugin that uses this mixin - the http_poller input - which has the same issues

karenzone commented 5 years ago

Cool. When we get this right, I'll fix for input-http_poller

jsvd commented 5 years ago

@karenzone do you mind also bumping the version and changelog?