search

logstash-plugins / logstash-filter-kv

Apache License 2.0
17 stars 42 forks source link

log: clarify action steps when timeouts cannot be enforced #93

Closed yaauie closed 2 years ago

yaauie commented 3 years ago

Prior message was technically accurate, but didn't lead users to action and created confusion:

KV Filter registered without jruby interruptible regular expressions enabled (-Djruby.regexp.interruptible=true); timeouts may not be respected.

Log message is now clearer about both intent and required actions to remediate:

KV Filter registered with timeout_millis safeguard enabled, but a required flag is missing so timeouts cannot be reliably enforced. Without this safeguard, runaway matchers in the KV filter may lead to high CPU usage and stalled pipelines. To resolve, add -Djruby.regexp.interruptible=true to your config/jvm.options and restart the Logstash process."

Additionally, we skip logging this message entirely if the plugin is explicitly configured with timeout_millis => 0 to disable timeouts.

kares commented 3 years ago

for the record, CI :red_circle: is not related to the changeset