search

logstash-plugins / logstash-filter-metrics

Apache License 2.0
15 stars 29 forks source link

Split metrics #17

Closed tebriel closed 6 years ago

tebriel commented 9 years ago

I am currently shipping data to datadog, and having the metrics broken up by what metric they're tracking when they're emitted is about 90% of my solution, so I've implemented it here. Thanks! Chris

elasticsearch-release commented 9 years ago

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

berglh commented 8 years ago

@tebriel Does this address this following issue by splitting each metric into a separate document?

Would be great to get this going so that we can track counts of logs from multiple sources.

tebriel commented 8 years ago

Yeah, that seems like what I implemented before. I now have a ruby filter followed by a split filter. This would be way better.

On May 24, 2016, at 8:20 PM, Berg Lloyd-Haig notifications@github.com<mailto:notifications@github.com> wrote:

@tebrielhttps://github.com/tebriel Does this address this following issue by splitting each metric into a separate document?

Would be great to get this going so that we can track counts of logs from multiple sources.

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHubhttps://github.com/logstash-plugins/logstash-filter-metrics/pull/17#issuecomment-221439982

berglh commented 8 years ago

Would be great to get this feature tested/merged so we can generate individual metric events per log source :+1:

tebriel commented 6 years ago

We don't use this any more, and I'm not in a position to resolve the merge conflicts and fix the PR, closing.

berglh commented 6 years ago

@tebriel I did fix up the diff and seemed to work for me after building:

https://github.com/berglh/logstash-filter-metrics/commit/7971a7d2cc744230496ab4b90e5ed9af6cd4bbd9

I should probably fix it up for a PR, but I'm not sure on writing ruby tests for plugins yet.

tebriel commented 6 years ago

@berglh good luck! I haven't touched a logstash plugin since this one in 2016, so I don't think I'd be much help but if I can help you please let me know.