search

logstash-plugins / logstash-filter-multiline

Apache License 2.0
18 stars 16 forks source link

Backport/metadata handling issue fixed in master #24

Closed purbon closed 8 years ago

purbon commented 9 years ago

Fixes #19 and #22 for the core-api-v1 (aka 1.x logstash-core) series of plugins.

purbon commented 9 years ago

@jsvd can you let me know your thought on this backport?

jsvd commented 9 years ago

Code LGTM, but we need to address the concurrent-ruby version problem before merging.. so if logstash-core is <=1.5.5 concurrent-ruby needs to be 0.9.1, but if > 1.5.5 then 0.9.2?

purbon commented 9 years ago

@jsvd as it's right now the gemfile is only helping on development environment. It will be harmless when installing the plugin/gem. what do you think?

jsvd commented 9 years ago

but doing bundle install && bundle exec rspec will break as soon as 1.5.6 is released, right? maybe we can pin down the logstash-core version only in the group?

purbon commented 9 years ago

well I guess as soon as 1.5.6 gets released we don't need this anymore. what do you think?

jsvd commented 9 years ago

ahh because 1.5.6 pins a specific version of concurrent-ruby instead of ~0.9.1? that still means we'll need to come to this plugin and remove the group definition, right?

jsvd commented 8 years ago

+1 on removing the concurrent-ruby pinning otherwise LGTM

jsvd commented 8 years ago

ah and please change the logstash-core dependency to < 2.0.0.alpha0 ?

purbon commented 8 years ago

works for me, thanks for your feedback.