cleanups and some optimizations

logstash-plugins / logstash-filter-mutate

Apache License 2.0

16 stars 75 forks source link

cleanups and some optimizations #59

Closed colinsurprenant closed 8 years ago

colinsurprenant commented 9 years ago

code cleanups
refactor big if sequence into a predefined mutators array
move some regex as constants

jsvd commented 8 years ago

Love all the refactoring! Minor comment that I think should be reverted but otherwise LGTM

purbon commented 8 years ago

LGTM in general, one proposal is to extract the "convertors" in his own class, then testability would get a ton better and also let us "reuse" them on demand. I think this will be also a good and easy to archive refactoring as you entered this land in this PR.

colinsurprenant commented 8 years ago

great. will merge, and only bump version in next PR #61

colinsurprenant commented 8 years ago

merged in master and pushed version 2.0.3 with PR #61