logstash-plugins / logstash-filter-mutate

Apache License 2.0
16 stars 75 forks source link

Add array_remove_duplicate. #94

Closed adamjt closed 6 years ago

adamjt commented 7 years ago

This PR addresses comments at:

https://github.com/logstash-plugins/logstash-filter-unique/issues/1

jordansissel commented 7 years ago

Code looks good.

Docs: Can you also add docs to docs/index.asciidoc for this new setting?

jordansissel commented 7 years ago

Also looks like there's a git conflict that needs resolving.

shoito commented 7 years ago

@adamjt I hope this to be merged🙏

adamjt commented 7 years ago

@shoito Whoops, I'll fix this up this week!

adamjt commented 7 years ago

@jordansissel @shoito I've updated the merge conflict and asciidoc - Travis is failing on something seemingly unrelated. invalid level[OFF] for logger[]

ekho commented 6 years ago

@adamjt could you push something to PR to trigger travis build? Issue with invalid level has been fixed at https://github.com/elastic/logstash/issues/8518

adamjt commented 6 years ago

@ekho All set, thanks!

ekho commented 6 years ago

@jordansissel all problems has been fixed. Could you merge PR ?

jordansissel commented 6 years ago

In future PRs, please disable your editor's "trim whitespace" feature as it makes the diff very noisy and hard to review.

jordansissel commented 6 years ago

Ahh, turns out we already have a filter to do this feature: https://github.com/logstash-plugins/logstash-filter-unique.

Let's use that filter instead.

adamjt commented 6 years ago

@jordansissel This PR was opened based off of https://github.com/logstash-plugins/logstash-filter-unique/issues/1

ekho commented 6 years ago

@jordansissel to use logstash-filter-unique my pr https://github.com/logstash-plugins/logstash-filter-unique/pull/2 should be merged.

andrewvc commented 6 years ago

@ekho apologies for the delay, we've just published a gem with your patch to the unique filter! Thanks for all the great work :) I'm going to close this PR as a result.