Enable multiple formats, a part from YAML to be used in this filter.

logstash-plugins / logstash-filter-translate

Translate filter for Logstash

Apache License 2.0

21 stars 47 forks source link

Closed purbon closed 8 years ago

purbon commented 9 years ago

Enables JSON and CSV, as well as YAML as formats that can be used as data formats to load dictionaries within this plugin.

Fixes partially #2

purbon commented 8 years ago

@guyboertje would you be so nice to give me your five cents here? thanks a lot.

andrewvc commented 8 years ago

Code generally looks good and tests pass! Will wait on feedback from my comments for an LGTM

purbon commented 8 years ago

@andrewvc feedback incorporated thanks a lot, is this good to merge? let me know what do you think.

andrewvc commented 8 years ago

LGTM! Thanks @purbon !

elasticsearch-bot commented 8 years ago

Pere Urbon merged this into the following branches!

Branch	Commits
master	31f7ee8eb6892c2dcf88b0fb24309d5856fee0bb, ad3ac17e4e6a532b31979ddcfc4b3471e33b08c3, cdfef459656edb6e47a0aa858d39a7c4a9f5a2bc, 099512dd5d01b98a5613a0c66ce57a35fd0a858d, 5fd9f6b51054255428d52c16a7d0da2fa8062d6b