logstash-plugins / logstash-filter-translate

Translate filter for Logstash
Apache License 2.0
21 stars 47 forks source link

Claimed: Translate Filter Configuration Example Incorrectly Includes Commas W/ Parameters #63

Closed MorrieAtElastic closed 6 years ago

MorrieAtElastic commented 6 years ago

Please post all product and debugging questions on our forum. Your questions will reach our wider community members there, and if we confirm that there is a bug, then we can open a new issue here.

For all general issues, please provide the following details for fast resolution:

Customer states that example given at https://www.elastic.co/guide/en/logstash/current/plugins-filters-translate.html is wrong and that parameters should not be terminated by commas:

filter {
  translate {
    dictionary => {
      "100"         => "Continue",
      "101"         => "Switching Protocols",
      "merci"       => "thank you",
      "old version" => "new version"
    }
  }
}

and that the correct syntax is:

filter {
  translate {
    dictionary => {
      "100"         => "Continue"
      "101"         => "Switching Protocols"
      "merci"       => "thank you"
      "old version" => "new version"
    }
  }
}

I am not in position to test this, but if confirmed, the documentation should be changed.

guyboertje commented 6 years ago

The claim that the docs are incorrect is correct! Will fix.

guyboertje commented 6 years ago

Fixed with PR #60, not released yet.