search

logstash-plugins / logstash-filter-translate

Translate filter for Logstash
Apache License 2.0
21 stars 47 forks source link

Note about setting override to clobber field #92

Closed kcm closed 2 years ago

kcm commented 2 years ago

If source and target are the same, you must set override to true, otherwise it will silently seem to fail, but yet not add a fallback value.

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

kcm commented 2 years ago

Resolves #55

kcm commented 2 years ago

Logstash 7.15.0 introduced new logic via the 3.3.0 version of this plugin, where override defaults to true for source==destination, so this note is only needed for all versions prior to Logstash 7.15.0.

cc @karenzone

andsel commented 2 years ago

Thanks @kcm for your contribution, as you pointed out with version 3.3.0 of the plugin when target has the same value of source the override option is implicitly true. So I think this PR could be closed.

kcm commented 2 years ago

@andsel I think it’s still needed for older docs versions, right?

mashhurs commented 2 years ago

closing as no work needed.