Closed mirolessev closed 3 years ago
💚 CLA has been signed
@mirolessev Can you please sign the CLA? it can be found here - https://www.elastic.co/contributor-agreement
Done
On Thu, May 27, 2021 at 9:46 PM Rob Bavey @.***> wrote:
@mirolessev https://github.com/mirolessev Can you please sign the CLA? it can be found here - https://www.elastic.co/contributor-agreement
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/logstash-plugins/logstash-input-azure_event_hubs/pull/66#issuecomment-849858541, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMVGZPPMUGH3ZTZBIO2DEJLTP2HP5ANCNFSM45JFM7EQ .
Done
On Tue, Jun 1, 2021 at 6:11 PM Rob Bavey @.***> wrote:
@.**** approved this pull request.
LGTM
Thank you the contribution - I tested this locally, and it worked as advertised.
Would you mind also adding an entry to the changelog, and updating the version https://github.com/logstash-plugins/logstash-input-azure_event_hubs/blob/master/VERSION ?
Once that is done, I can go ahead and merge the code, and publish the plugin
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/logstash-plugins/logstash-input-azure_event_hubs/pull/66#pullrequestreview-673202305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMVGZPM3XQ5EQAPM4JO2LBTTQT2DBANCNFSM45JFM7EQ .
@mirolessev Thank you for your contribution - version 1.3.0
of this plugin with your update in it has been published!
@robbavey will this updated plugin be made part of the logstash docker image?
@aaron-dsouza it will for 7.14.
Add EventHub user properties in @metadata object
Release notes
What does this PR do?
Why is it important/What is the impact to the user?
This PR add EventHub user properties in @metadata object.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
You can access EventHub metadata in logstash pipeline
Screenshots
Logs