logstash-plugins / logstash-input-azure_event_hubs

Logstash input for consuming events from Azure Event Hubs
Apache License 2.0
18 stars 30 forks source link

Add EventHub user properties in @metadata object #66

Closed mirolessev closed 3 years ago

mirolessev commented 3 years ago

Add EventHub user properties in @metadata object

Release notes

What does this PR do?

Why is it important/What is the impact to the user?

This PR add EventHub user properties in @metadata object.

Checklist

Author's Checklist

How to test this PR locally

  1. Create EventHub message
    • Add body data (any JSON Object)
    • Add user properties as a metadata
  2. Send message to EventHub
  3. Consume message from EventHub and check [@metadata][user_properties]

Related issues

Use cases

You can access EventHub metadata in logstash pipeline

Screenshots

Logs

cla-checker-service[bot] commented 3 years ago

💚 CLA has been signed

robbavey commented 3 years ago

@mirolessev Can you please sign the CLA? it can be found here - https://www.elastic.co/contributor-agreement

mirolessev commented 3 years ago

Done

On Thu, May 27, 2021 at 9:46 PM Rob Bavey @.***> wrote:

@mirolessev https://github.com/mirolessev Can you please sign the CLA? it can be found here - https://www.elastic.co/contributor-agreement

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/logstash-plugins/logstash-input-azure_event_hubs/pull/66#issuecomment-849858541, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMVGZPPMUGH3ZTZBIO2DEJLTP2HP5ANCNFSM45JFM7EQ .

mirolessev commented 3 years ago

Done

On Tue, Jun 1, 2021 at 6:11 PM Rob Bavey @.***> wrote:

@.**** approved this pull request.

LGTM

Thank you the contribution - I tested this locally, and it worked as advertised.

Would you mind also adding an entry to the changelog, and updating the version https://github.com/logstash-plugins/logstash-input-azure_event_hubs/blob/master/VERSION ?

Once that is done, I can go ahead and merge the code, and publish the plugin

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/logstash-plugins/logstash-input-azure_event_hubs/pull/66#pullrequestreview-673202305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMVGZPM3XQ5EQAPM4JO2LBTTQT2DBANCNFSM45JFM7EQ .

robbavey commented 3 years ago

@mirolessev Thank you for your contribution - version 1.3.0 of this plugin with your update in it has been published!

aaron-dsouza-zz commented 3 years ago

@robbavey will this updated plugin be made part of the logstash docker image?

roaksoax commented 3 years ago

@aaron-dsouza it will for 7.14.