Fix connection placeholder replacements errors

edmocosta commented 1 month ago

Release notes

Fixed connection placeholder replacements errors when running Logstash 8.15.1 and 8.15.2 versions

What does this PR do?

Logstash 8.15.1 changed the replace_placeholders method adding a new boolean argument to it. The plugins is still calling that method with a single argument, which leads to an error and failure to initialize Logstash.

Why is it important/What is the impact to the user?

Checklist

[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have made corresponding change to the default configuration files (and/or docker env variables)
[ ] I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

Run a simple pipeline using this plugins with Logstash 8.15.1 and previous version.

Related issues

Logs

Error parsing event hub string name for connection: '' please ensure that the connection string contains the EntityPath

JulienOrain commented 1 month ago

Hello I am not familiar with the release process of logstash and logstash plugins. Do you know when this MR and the version v1.4.8 will be release in logstash (probably in a 8.15.3) ? Thanks

edmocosta commented 1 month ago

Hello I am not familiar with the release process of logstash and logstash plugins. Do you know when this MR and the version v1.4.8 will be release in logstash (probably in a 8.15.3) ? Thanks

Hi @JulienOrain! The latest version of this plugin will be released with Logstash 8.15.3. Meanwhile, you can upgrade it by running:

bin/logstash-plugin update logstash-input-azure_event_hubs

Thanks!

JulienOrain commented 1 month ago

Awesome ! Thanks a lot !

logstash-plugins / logstash-input-azure_event_hubs