Allow support for optional filters for `AWS/EC2` namespace

logstash-plugins / logstash-input-cloudwatch

A Logstash input to pull events from the Amazon Web Services CloudWatch API

Apache License 2.0

43 stars 27 forks source link

Allow support for optional filters for `AWS/EC2` namespace #36

Closed robbavey closed 6 years ago

robbavey commented 6 years ago

This commit brings in #13 and also includes fixes to ensure that this plugin is compatible with v2 of the AWS Ruby SDK

robbavey commented 6 years ago

@karenzone Would you mind double checking my doc changes?

karenzone commented 6 years ago

This suggestion is related to a section you didn't change, so the review process won't let me enter comments in line. I would appreciate it if you could correct them.

The heading at line 57 isn't formatted correctly. (Should be tagged with =====.)
In the examples, only the first one is rendering correctly. The 2nd and 3rd need to have [source,ruby] added to them.

karenzone commented 6 years ago

LGTM. Builds cleanly

elasticsearch-bot commented 6 years ago

Rob Bavey merged this into the following branches!

Branch	Commits
master	5bbbaf6d94d6de8d5383d1b904a2e8a1a01d69d9, a92ea3c789d99e820892dbba7adaeac38e07f97a, b3df49211b500e9dda7587b2d7f5625ce44c22b8, 9498d06f2c4c786a947adbf0461fee0e09dfd1ba, 7639aabde306b1fb3d69c8cf6599d6f0e66defe0, 5c4bf6b403a623608cc63118d72336b8aee46bc9, 641596afe479e4329128ef04ff42b2987a52dd30