search

logstash-plugins / logstash-input-file

Apache License 2.0
68 stars 101 forks source link

Force logstash-devutils to 1.3 (avoid 2.0) to make the tests green #258

Closed andsel closed 4 years ago

andsel commented 4 years ago

This PR forces the dependency on logstash-devutils gem to a version < 2.0 to make the CI green

elasticsearch-bot commented 4 years ago

Andrea Selva merged this into the following branches!

Branch Commits
master fcea343e31dcda4eff7fc4b5a9365d7b756638d5
jsvd commented 4 years ago

@andsel @kares is there anything we could sort out in 2.x to avoid pinning this gem to 1.x? Is this the issue?

andsel commented 4 years ago

@jsvd yes was it, but when I explicitly require the logstash/devutils/rspec/shared_example to force the including of the shared test cases, the build hang up, never terminating.

kares commented 4 years ago

right, we should keep loading the shared example - seems its used quite in the wild. as for the others not sure but than we might want also keep auto-loading the insist gem.

last but not least the pipeline expectations in tests might not be 100% the same as in devutils 1.3. API should be duck-type compatible but its a different pipeline impl - probably smt @andsel run into. so allowing an auto-magic devutils upgrade might end up confusing.

than on the other hand I thought plugins specify a requirement (likely only looked at one plugin before which actually does) but its common to just add_development_dependency 'logstash-devutils'

maybe we should just yank the 2.0 devutils gem, for now? or do we deliver updates (mentioned above) and hope most work with Java pipeline?