search

logstash-plugins / logstash-input-file

Apache License 2.0
68 stars 101 forks source link

Mark fully read zip file completed in sincedb #287

Open max-frank opened 3 years ago

max-frank commented 3 years ago

This PR fixes #286

Note that this PR is currently missing a unit test for this as I am not really sure how to write one as I am not a ruby developer. I think checking the @path_in_sincedb value after a complete read should be work as a unit test.

cla-checker-service[bot] commented 3 years ago

❌ Author of the following commits did not sign a Contributor Agreement: 4f4913b9155f2ec6afa87dd64de50580f5e5cca4

Please, read and sign the above mentioned agreement if you want to contribute to this project

max-frank commented 3 years ago

Note on the CLA I signed it as of 3/26/2021 10:56:27 AM (timestamp according to the DocuSign document)

max-frank commented 3 years ago

I am not to sure what is going on with this issue image

The test seems to randomly fail. I believe this random failures are unrelated to the code changes of this PR. Note that this same random failures seem to occur for #289