search

logstash-plugins / logstash-input-gelf

Apache License 2.0
20 stars 39 forks source link

Remove wrong underscore escaping in docs #3

Closed wbolster closed 9 years ago

wbolster commented 9 years ago

The docs at http://logstash.net/docs/1.4.2/inputs/gelf show the backslashes, so the escaping seems wrong.

suyograo commented 9 years ago

@wbolster can you please perform step 2 of https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps

wbolster commented 9 years ago

@suyograo I'm sorry, but i'm not going through bureaucratic processes for removing 5 superfluous backslashes in a piece of documentation. This is a trivial contribution (no code changes, no new ideas, just fixing a few typos) which can be accepted as-is, without further ado.

purbon commented 9 years ago

Im sorry to read that @wbolster, I'm closing this PR for now, in case you change your mind feel free to reopen it here, Thanks a lot for your contribution.

/cheers

wbolster commented 9 years ago

How disappointing. JUST FIX THE FORMATTING TYPO and be done with it instead of wasting everyones time.

Your external contribution process is severely broken. I will surely refrain from contributing to such unwelcoming projects in the future.

purbon commented 9 years ago

@wbolster CLA are used in many open source projects and are in benefits of all sides, a good reading is at: https://www.chef.io/blog/2009/08/11/why-we-chose-the-apache-license/

Where they exactly say this:

The requirement for the CLA is for everyone’s protection – end users can be sure that the code is free from legal entanglements, developers can be certain their rights are explicit, and companies canbe assured that by using the software they don’t expose themselves to any additional legal risk.

/cheers

wbolster commented 9 years ago

this is not about code, as i mentioned in an earlier comment MONTHS AGO. this is about a typo. that's right. about. a. tpyo.

colinsurprenant commented 9 years ago

@wbolster we realize that the proposed changes are about fixing typos but please understand that regardless of the nature of the change in the PR, it cannot be merged unless the CLA is signed.

I understand your frustration and I am sorry it took so long we took action on this PR. We do have a huge amount of issues and PRs to deal with and we are trying our best to better manage this. On that subject we have an open discussion on https://discuss.elastic.co/t/progress-for-logstash-contributions/27796 - you are welcome to chime in.

Again, thanks for the heads up and proposed changes, if you decide to sign the CLA, we'll look forward to merge it. In any case, we do appreciate you pointed that out to us.