Closed edefaria closed 7 years ago
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.
@edefaria thanks for this! can you please add some tests?
Are there docs on the TCP protocol for GELF? I don't see any on the gelf site.
Gelf TCP is the same as UDP. The only thing is you need a delimit for your payload, by default on graylog/gelf is nul '\0'. Also Graylog GELF TCP does not support compression, so most of the GELF library over TCP disable compression for TCP.
I will see to add test and new api support.
Is there a timetable for if / when this will be merged?? Is there anything left to do, wouldn't mind helping if its needed.
@ddelnano It could help if some folks helped with any of the following:
@jordansissel since July we have moved away from logstash, I appreciate the response tho.
This PR makes a number of changes that seem unrelated to adding TCP support:
I'm not sure what to make of this.
What's the status of this PR? If it gets merged in the official plugin we don't have to build a custom one for us.
Anyone who is using this plugin extensively want to step up and volunteer to help maintain this plugin?
https://discuss.elastic.co/t/logstash-plugins-community-maintainers/35953
This PR's been idle for some time. I'm going to close it because I don't know how to get clarity on the proposed change as compared to the patch provided.
We can still add TCP support for GELF input, but for whoever does, please include rspec tests, some indication of what product(s) you used to test it.
Add TCP protocol support.
Based on #6,